Todd Lipcon has posted comments on this change. Change subject: gutil: stop supporting AMD Opteron K8 (take 2) ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6680/1/src/kudu/gutil/atomicops-internals-x86.cc File src/kudu/gutil/atomicops-internals-x86.cc: Line 70: static void AtomicOps_Internalx86CPUFeaturesInit() { > Is this guaranteed to load before glog? If not, what will happen in the LOG well, I think it's handier to just use a constructor function. tcmalloc seems to have switched to a module initializer as well, but they forgot to mark it static. LOG(FATAL) still works even if glog isn't initted yet. It might not go to the right log file, but I think that's fine since this is so rare. PS1, Line 107: 0fh > 0fh == 0x0f? Is that typical parlance? yea that's what they call it in docs, etc. -- To view, visit http://gerrit.cloudera.org:8080/6680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4eff19c62741e7433e378f7e0725079ecbcf1a97 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
