Dan Burkert has posted comments on this change. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error ......................................................................
Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/6640/9/src/kudu/client/client.h File src/kudu/client/client.h: Line 528: friend class kudu::SecurityUnknownTskTest; the kudu:: namespace shouldn't be necessary here. http://gerrit.cloudera.org:8080/#/c/6640/9/src/kudu/integration-tests/security-unknown-tsk-itest.cc File src/kudu/integration-tests/security-unknown-tsk-itest.cc: Line 216: gscoped_ptr<KuduTableCreator> table_creator(client->NewTableCreator()); Is it necessary to have more than a single tablet for this test to exercise the TSK logic? If not I'd recommend cutting this. If it is, consider using hash partitioning, which should just require a single statement. Line 287: // path: the meta-cache already contains information on the corresponding Is there a different error that occurs if a meta-cache lookup happens? Line 335: if (!importer_do_run) { If this is just for short circuiting the failure case, why not just not join on the thread and let it die naturally? -- To view, visit http://gerrit.cloudera.org:8080/6640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87d780a4ad88c15ceaacfddf6c1b69ed053bb959 Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
