Grant Henke has posted comments on this change. Change subject: env: Always read fully when reading files ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6758/4/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 1457: void InitDefaultEnv() { default_env = new PosixEnv; } > These aren't in the anonymous namespace, so they should either remain stati My bad, a bad find and replace. -- To view, visit http://gerrit.cloudera.org:8080/6758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735cd4cfca3c355226266ef4f0fdb57bf59dfe69 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
