Adar Dembo has submitted this change and it was merged. Change subject: env: Always read fully when reading files ......................................................................
env: Always read fully when reading files In KUDU-9 env_util::ReadFully was added to ensure short reads were retried until all data was read. Later RWFile was implemented with “read fully” behavior by default. (see a15c795360e32885c00442efacd2a345f993f425) Given we almost always use ReadFully or expect the data to be fully read regardless, this patch moves the “read fully” behavior into the Read function so it is always used. Change-Id: I735cd4cfca3c355226266ef4f0fdb57bf59dfe69 Reviewed-on: http://gerrit.cloudera.org:8080/6758 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <a...@cloudera.com> --- M src/kudu/consensus/log_util.cc M src/kudu/fs/file_block_manager.cc M src/kudu/fs/log_block_manager-test.cc M src/kudu/tserver/tablet_copy_client-test.cc M src/kudu/tserver/tablet_copy_service-test.cc M src/kudu/tserver/tablet_copy_source_session.cc M src/kudu/tserver/tablet_copy_source_session.h M src/kudu/util/env-test.cc M src/kudu/util/env_posix.cc M src/kudu/util/env_util.cc M src/kudu/util/env_util.h M src/kudu/util/pb_util-test.cc M src/kudu/util/pb_util.cc 13 files changed, 78 insertions(+), 164 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I735cd4cfca3c355226266ef4f0fdb57bf59dfe69 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
