Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6733
to look at the new patch set (#3).
Change subject: KUDU-1853 (redux). tablet copy: Don't orphan blocks on failure
......................................................................
KUDU-1853 (redux). tablet copy: Don't orphan blocks on failure
Previously, if a tablet copy failed we would orphan data blocks. This
patch makes it so that a failed tablet copy operation that does not
involve a process crash does not orphan data blocks.
This also refactors some deletion logic out of TSTabletManager so that
TabletCopyClient will tombstone partially-copied tablets when the copy
operation fails.
This version of the patch addresses and tests for a data loss issue
(KUDU-1968) that was merged along with a previous version of this patch,
and released with Kudu 1.3.0, before it was reverted in Kudu 1.3.1.
Additional changes in the revised patch:
* Don't check that block ids do not overlap between source and
destination in tablet_copy_client-test since that's not guaranteed.
* Attempt to detect data loss in tablet_copy_client-test and fail the
test if detected. In the case of the log block manager, this check is
currently not reliable due to KUDU-1980.
* Rename old_superblock_ to remote_superblock_ in
TabletCopyClientSession.
Originally committed as 72541b47eb55b2df4eab5d6050f517476ed6d370 before
being reverted due to KUDU-1968.
Change-Id: Ic999ccd27859ace0d635255e86729dff8e1d8349
---
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/tserver/tablet_copy-test-base.h
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_copy_client.cc
M src/kudu/tserver/tablet_copy_client.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
8 files changed, 368 insertions(+), 203 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/6733/3
--
To view, visit http://gerrit.cloudera.org:8080/6733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic999ccd27859ace0d635255e86729dff8e1d8349
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
