Mike Percy has posted comments on this change. Change subject: KUDU-1853 (redux). tablet copy: Don't orphan blocks on failure ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6733/3/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: PS3, Line 473: TODO(mpercy): We can : // orphan up to a RowSet's worth of blocks if tablet copy fails. Make a : // tighter bound. > Can't we fix this by using a loop like this (for etc. the column data): Don't know why I didn't think of that. Done. -- To view, visit http://gerrit.cloudera.org:8080/6733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic999ccd27859ace0d635255e86729dff8e1d8349 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
