Todd Lipcon has posted comments on this change. Change subject: WIP: cfile_set: avoid Status allocation for row not found ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6804/1/src/kudu/tablet/cfile_set.cc File src/kudu/tablet/cfile_set.cc: Line 221: } else if (!s.ok()) { > warning: don't use else after return [readability-else-after-return] Done http://gerrit.cloudera.org:8080/#/c/6804/1/src/kudu/tablet/cfile_set.h File src/kudu/tablet/cfile_set.h: Line 111: Status NewKeyIterator(CFileIterator **iter) const; > warning: function 'kudu::tablet::CFileSet::NewKeyIterator' has a definition Done -- To view, visit http://gerrit.cloudera.org:8080/6804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3056aaaf0eec6b7deebcd1f206cb551b75996927 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
