Todd Lipcon has posted comments on this change. Change subject: cfile_set: avoid Status allocation for row not found ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6804/2/src/kudu/tablet/cfile_set.cc File src/kudu/tablet/cfile_set.cc: PS2, Line 238: s.IsNotFound() > If this is also a common case, it should be converted in the same way. not that common, since the bloom filter above already cuts out 99.99% of cases or somesuch http://gerrit.cloudera.org:8080/#/c/6804/2/src/kudu/tablet/diskrowset.cc File src/kudu/tablet/diskrowset.cc: Line 615: Status DiskRowSet::MutateRow(Timestamp timestamp, > Likewise with the various NotFound() exits from here. yea, that's a little trickier though, since we don't have a pre-existing out-param handy. -- To view, visit http://gerrit.cloudera.org:8080/6804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3056aaaf0eec6b7deebcd1f206cb551b75996927 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
