Hello David Ribeiro Alves, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6823
to review the following change.
Change subject: log block manager: convert container metrics from counters to
gauges
......................................................................
log block manager: convert container metrics from counters to gauges
Container deletion is just around the corner, so these metrics need to
become gauges so that they can be decremented.
As an aside, it's possible that we've already been mishandling these
counters: they should never drop in value, even across restarts, and we were
incrementing them every time a container was reopened at startup. However,
we may have been OK because the block manager loads before the web UI, so by
the time the metrics are fetchable, the counter values should be the same as
what they were pre-restart.
Change-Id: I343d99d42da7f4fbc0facb476c97f2ca8785031d
---
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
2 files changed, 18 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/6823/1
--
To view, visit http://gerrit.cloudera.org:8080/6823
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I343d99d42da7f4fbc0facb476c97f2ca8785031d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
