Adar Dembo has submitted this change and it was merged. Change subject: log block manager: convert container metrics from counters to gauges ......................................................................
log block manager: convert container metrics from counters to gauges Container deletion is just around the corner, so these metrics need to become gauges so that they can be decremented. As an aside, it's possible that we've already been mishandling these counters: they should never drop in value, even across restarts, and we were incrementing them every time a container was reopened at startup. However, we may have been OK because the block manager loads before the web UI, so by the time the metrics are fetchable, the counter values should be the same as what they were pre-restart. Change-Id: I343d99d42da7f4fbc0facb476c97f2ca8785031d Reviewed-on: http://gerrit.cloudera.org:8080/6823 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <t...@apache.org> --- M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.cc 2 files changed, 18 insertions(+), 26 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I343d99d42da7f4fbc0facb476c97f2ca8785031d Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
