William Li has posted comments on this change. Change subject: KUDU-1192 Periodically flush glog buffers from a thread ......................................................................
Patch Set 2: (2 comments) removed the changes from other files as well. http://gerrit.cloudera.org:8080/#/c/6853/1/src/kudu/util/async_logger.cc File src/kudu/util/async_logger.cc: Line 34: wrapped_(DCHECK_NOTNULL(wrapped)), > rather than using an env var, should use a gflag for the period at which th yup. make things much simplier? Line 54: CHECK_EQ(state_, RUNNING); > instead of a separate thread, why not just change the existing thread so th Done -- To view, visit http://gerrit.cloudera.org:8080/6853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4c6d440e9259efcf222530f13137f7de5bf00fc Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: William Li <william...@inspur.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: William Li <william...@inspur.com> Gerrit-HasComments: Yes
