William Li has posted comments on this change. Change subject: KUDU-1192 Periodically flush glog buffers from a thread ......................................................................
Patch Set 6: (3 comments) done the fixes. Also added the SetCommandLineOptionWithMode per suggestion, although I am not sure if additional tests need to be written for that. Seem there are already good tests for the SetCommandLineOptionWithMode already. So if need to add our own tests, please let me know. http://gerrit.cloudera.org:8080/#/c/6853/5/src/kudu/util/async_logger.cc File src/kudu/util/async_logger.cc: PS5, Line 120: regardless wheth > "regardless whether there is" Done http://gerrit.cloudera.org:8080/#/c/6853/5/src/kudu/util/logging-test.cc File src/kudu/util/logging-test.cc: Line 175: // Wait a little more than one wake-up cycle. > nit: capitalize sentence and end in '.' Done PS5, Line 180: flush > nit: flushed Done -- To view, visit http://gerrit.cloudera.org:8080/6853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4c6d440e9259efcf222530f13137f7de5bf00fc Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: William Li <william...@inspur.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: William Li <william...@inspur.com> Gerrit-HasComments: Yes
