Adar Dembo has posted comments on this change. Change subject: [webui] Improvements for when there's many tablets & cleanup ......................................................................
Patch Set 1: (4 comments) Do the pages look OK and load reasonably quickly when the number of tablets is high (say, 1000+)? http://gerrit.cloudera.org:8080/#/c/6870/1//COMMIT_MSG Commit Message: Line 17: 4. Detailed tablet tables use table-hover so it's easier to 5. http://gerrit.cloudera.org:8080/#/c/6870/1/src/kudu/master/master-path-handlers.cc File src/kudu/master/master-path-handlers.cc: Line 256: TabletMetadataLock l(tablet.get(), TabletMetadataLock::READ); Would it be possible to combine all of this with the work in L278+ to avoid locking the tablets twice? http://gerrit.cloudera.org:8080/#/c/6870/1/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: Line 424: " <script src='/jquery-1.11.1.min.js' defer></script>" I noticed we include this already in www/metrics.html. Should we remove it from there? Or does the page header not get applied to that page? http://gerrit.cloudera.org:8080/#/c/6870/1/src/kudu/tserver/tserver-path-handlers.cc File src/kudu/tserver/tserver-path-handlers.cc: PS1, Line 243: replica->tablet()->mem_tracker() Can this actually be null? -- To view, visit http://gerrit.cloudera.org:8080/6870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
