Dan Burkert has posted comments on this change. Change subject: [webui] Improvements for when there's many tablets & cleanup ......................................................................
Patch Set 3: (2 comments) Thanks for doing this! Definitely a step forward in usability. http://gerrit.cloudera.org:8080/#/c/6870/3//COMMIT_MSG Commit Message: Line 13: 2. /tablets has a toggle-collapse detailed table of tablets. I'm not sure this is an improvement, since there is no content under the tablets list. Seems like most of the time we will be clicking expand anyway. On the tables page it makes sense, in order to get a view of what's under that tables list. Line 29: Also I added a memory usage column to the detailed tablets I'm concerned it may be misleading to call this 'memory usage', since it only accounts for the write buffers. What do you think about calling it 'write buffer memory usage'? Too jargony? -- To view, visit http://gerrit.cloudera.org:8080/6870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes