Alexey Serbin has posted comments on this change. Change subject: KUDU-1034 client does not failover due to timeout ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6924/1/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: PS1, Line 450: for (int i = 0; i < 1000; i++) { : if (workload.rows_inserted() >= rows_target) break; : SleepFor(MonoDelta::FromMilliseconds(10)); : } It seems this test does not provide the necessary coverage: the Workload does some cycling internally, and that's not exactly what we need to test the retry in case of a timeout. -- To view, visit http://gerrit.cloudera.org:8080/6924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfcece485e4053d921ffdc865612b3e7b9a992a3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes