Alexey Serbin has posted comments on this change. Change subject: KUDU-1034 client does not failover due to timeout ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/6924/4/src/kudu/integration-tests/client_failover-itest.cc File src/kudu/integration-tests/client_failover-itest.cc: PS4, Line 252: tserver::TabletServerIntegrationTestBase > why not ExternalMiniClusterITestBase? Because it's using GetLeaderReplicaWithRetries() which currently exists only in TabletServerIntegrationTestBase Do you think it would be a good idea to move that GetLeaderReplicaWithRetries and all of its dependencies into cluster_itest_util.h or around? http://gerrit.cloudera.org:8080/#/c/6924/4/src/kudu/rpc/retriable_rpc.h File src/kudu/rpc/retriable_rpc.h: Line 167: // A note regarding ServerPicker::MarkServerFailed() calls in this method: > I know I mentioned adding a comment but I was thinking just a 2- or 3-line The MarkServerFailed signature in ServerPicker assumes it can mark the whole server as failed. It's just a detail of current implementation of that method in MetaCacheServerPicker. Do you mean we want to have this comment not here but in MetaCacheServerPicker? PS4, Line 195: MarkServerFailed > Should we rename this method to MarkReplicaFailed for clarity? I'm not sure about this: from the semantics of the error code SERVER_NOT_ACCESSIBLE you would assume it makes sense to mark the whole server failed. As I understand it, teplica is not relevant in this context. The same for the call of the same method in case of TimedOut status returned along with NON_RERTRIABLE_ERROR -- To view, visit http://gerrit.cloudera.org:8080/6924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfcece485e4053d921ffdc865612b3e7b9a992a3 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
