Todd Lipcon has posted comments on this change. Change subject: Add script to run clang-tidy against a patch ......................................................................
Patch Set 3: (6 comments) > Forgot to ask: how is clang_tidy_gerrit.py invoked? There's a jenkins job here: http://104.196.14.100/job/kudu-tidy-bot/ It's currently pointed at my personal git repo but once this is committed I'll update it to use master. http://gerrit.cloudera.org:8080/#/c/4381/3/build-support/clang_tidy_gerrit.py File build-support/clang_tidy_gerrit.py: PS3, Line 34: CLANG_TIDY_DIFF = os.path.join( : ROOT, "thirdparty/installed/uninstrumented/share/clang/clang-tidy-diff.py") : CLANG_TIDY = os.path.join( : ROOT, "thirdparty/installed/uninstrumented/bin/clang-tidy") > Can we use paths to clang-toolchain here instead? Only for bin/. The python script doesn't end up installed. Line 39: GIT="git" > Not used? Done Line 67: print "l", l > Unreachable code? Done Line 128: class TestClangTidyGerrit(unittest.TestCase): > Still want to keep this? sure. I know it doesn't get run by any CI, but it was a useful test during dev, and will be useful if we need to tweak the parsing at some point. http://gerrit.cloudera.org:8080/#/c/4381/3/build-support/compile_flags.py File build-support/compile_flags.py: PS3, Line 29: TODO(todd) it would be nicer to somehow grab these from CMake, but it's : not clear how to do so. > I don't see how that would be possible given that cmake's list of flags is yea, though I was thinking we could run cmake with a standard (non-san, etc) build, and somehow get it to export the flags into a file somewhere as part of running 'cmake'. I couldn't figure out how to do that, though. Line 39: '-Dintegration_tests_EXPORTS', > This one is odd; do you know why it's included? CMake doesn't explicitly se hrm, no... my clang must have set it at some point whenever I copied this from some compilation string. Removed. -- To view, visit http://gerrit.cloudera.org:8080/4381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c6246f4691b0ca143eea4aa8fb6a4b23099ce4e Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes