Adar Dembo has posted comments on this change. Change subject: Add script to run clang-tidy against a patch ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4381/3/build-support/compile_flags.py File build-support/compile_flags.py: PS3, Line 29: TODO(todd) it would be nicer to somehow grab these from CMake, but it's : not clear how to do so. > yea, though I was thinking we could run cmake with a standard (non-san, etc You could pick your favorite test, find its flags.make, and concatenate CXX_FLAGS, CXX_DEFINES, and CXX_INCLUDES together. For example: adar@adar-ThinkPad-T540p:~/Source/kudu/build/debug$ cat src/kudu/tserver/CMakeFiles/tserver_test_util.dir/flags.make # CMAKE generated file: DO NOT EDIT! # Generated by "Unix Makefiles" Generator, CMake Version 3.5 # compile CXX with /usr/lib/ccache/c++ CXX_FLAGS = -msse4.2 -Wall -Wno-sign-compare -Wno-deprecated -pthread -fno-strict-aliasing -DBOOST_DATE_TIME_POSIX_TIME_STD_CONFIG -ggdb -std=c++11 -g -fPIC -fPIC CXX_DEFINES = -DKUDU_HEADERS_NO_STUBS=1 -DKUDU_HEADERS_USE_RICH_SLICE=1 -DKUDU_HEADERS_USE_SHORT_STATUS_MACROS=1 -DKUDU_STATIC_DEFINE -D__STDC_FORMAT_MACROS -Dtserver_test_util_EXPORTS CXX_INCLUDES = -I/home/adar/Source/kudu/build/debug/src -I/home/adar/Source/kudu/src -isystem /home/adar/Source/kudu/thirdparty/installed/common/include -isystem /home/adar/Source/kudu/thirdparty/installed/uninstrumented/include -- To view, visit http://gerrit.cloudera.org:8080/4381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c6246f4691b0ca143eea4aa8fb6a4b23099ce4e Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
