Mike Percy has posted comments on this change. Change subject: Use the same replica selection when adding a server as table creation ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7143/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 3248: vector<shared_ptr<TSDescriptor> > two_choices; nit: in c++11 using >> is no longer a compiler parse error so no need for the space in between the brackets Line 3255: if (two_choices.size() == 1) { Why remove the CHECK from L3901 in the previous version of the file? -- To view, visit http://gerrit.cloudera.org:8080/7143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I199e7a59c2c7832e7a87842b357ba3aa29e34685 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
