Adar Dembo has posted comments on this change.

Change subject: Use the same replica selection when adding a server as table 
creation
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7143/1/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

Line 3352:       rng_(GetRandomSeed32()) {
> What's your advice on how to do that? If you copy it then that would copy t
Yeah I think a bare pointer to the RNG should be fine (for the reason you 
provided).


-- 
To view, visit http://gerrit.cloudera.org:8080/7143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I199e7a59c2c7832e7a87842b357ba3aa29e34685
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-HasComments: Yes

Reply via email to