Edward Fancher has posted comments on this change. Change subject: KUDU-2004: Undefined behavior in TlsSocket::Writev() ......................................................................
Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/7141/9/src/kudu/util/net/socket.h File src/kudu/util/net/socket.h: PS9, Line 123: // Write up to 'amt' bytes from 'buf' to the socket. The number of bytes : // actually written will be stored in 'nwritten'. If an error is returned, > Did you see my suggestion in CR 4 for this comment? Sorry, I made a mistake in translating the line numbers from tls_socket.h to socket.h and I fixed the wrong comment. Should be better now. -- To view, visit http://gerrit.cloudera.org:8080/7141 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5b5bbb3fd2ec8fcd1a48873446f3aa09546eaac Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Edward Fancher <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Edward Fancher <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
