Edward Fancher has posted comments on this change. Change subject: Undefined behavior in TlsSocket::Writev() ......................................................................
Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/7141/4/src/kudu/security/tls_socket.cc File src/kudu/security/tls_socket.cc: PS4, Line 80: if (!write_status.ok()) break; : > I think this comment can be simplified by saying something like: Removed this per Adar. PS4, Line 84: if (*nwritten < frame_size) break; > How about: Removed this per Adar. http://gerrit.cloudera.org:8080/#/c/7141/4/src/kudu/security/tls_socket.h File src/kudu/security/tls_socket.h: Line 35: Status Write(const uint8_t *buf, int32_t amt, int32_t *nwritten) override WARN_UNUSED_RESULT; > +1 for moving to class declaration for Socket. Done -- To view, visit http://gerrit.cloudera.org:8080/7141 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5b5bbb3fd2ec8fcd1a48873446f3aa09546eaac Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Edward Fancher <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Edward Fancher <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
