Alexey Serbin has posted comments on this change. Change subject: Rename MiniCluster to InternalMiniCluster ......................................................................
Patch Set 1: (3 comments) just some nits, overall looks good http://gerrit.cloudera.org:8080/#/c/7272/1/src/kudu/integration-tests/internal_mini_cluster-itest-base.h File src/kudu/integration-tests/internal_mini_cluster-itest-base.h: PS1, Line 18: #ifndef KUDU_INTEGRATION_TESTS_MINI_CLUSTER_ITEST_BASE_H_ : #define KUDU_INTEGRATION_TESTS_MINI_CLUSTER_ITEST_BASE_H_ nit: consider either updating this guards to reflect the change in the name, or (better) using '#pragma once' instead PS1, Line 21: #include <gtest/gtest.h> while you are at it, could you move it after the std headers? http://gerrit.cloudera.org:8080/#/c/7272/1/src/kudu/integration-tests/internal_mini_cluster.h File src/kudu/integration-tests/internal_mini_cluster.h: PS1, Line 18: #ifndef KUDU_INTEGRATION_TESTS_MINI_CLUSTER_H : #define KUDU_INTEGRATION_TESTS_MINI_CLUSTER_H nit: #pragma once? -- To view, visit http://gerrit.cloudera.org:8080/7272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bd326a7a46f039e18c47b8e23ee1427ccf281be Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
