Adar Dembo has posted comments on this change. Change subject: Rename MiniCluster to InternalMiniCluster ......................................................................
Patch Set 1: (1 comment) I think it'd also be nice to rename MiniTabletServer and MiniMaster, though I'm happy to see that done in a separate patch. http://gerrit.cloudera.org:8080/#/c/7272/1/src/kudu/tools/ksck_remote-test.cc File src/kudu/tools/ksck_remote-test.cc: Line 193: std::shared_ptr<InternalMiniCluster> mini_cluster_; Any idea why this is a shared_ptr? Seems like it could be a unique_ptr. -- To view, visit http://gerrit.cloudera.org:8080/7272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bd326a7a46f039e18c47b8e23ee1427ccf281be Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
