Adar Dembo has posted comments on this change. Change subject: Use dynamic bind address for internal + external mini clusters ......................................................................
Patch Set 2: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/7274/2/src/kudu/integration-tests/internal_mini_cluster.cc File src/kudu/integration-tests/internal_mini_cluster.cc: Line 124: mini_masters_.push_back(std::move(mini_master)); Nit: should emplace_back() here. Line 161: mini_masters_.push_back(std::move(mini_master)); Nit: should emplace_back() here. http://gerrit.cloudera.org:8080/#/c/7274/1/src/kudu/integration-tests/internal_mini_cluster.h File src/kudu/integration-tests/internal_mini_cluster.h: Line 66: std::vector<uint16_t> master_rpc_ports; > changed to "list of all zeroes" So I get that "list of all zeroes" is the _semantic_ effect, but take a look at how the default for data_root is described: it gives you both the _actual_ default (empty string) and the effect (auto-generate a unique path). That's why I suggested "empty list" here, so you'd capture both the actual default value in case someone wants to overwrite it as well as the effect it has since it's non-obvious. http://gerrit.cloudera.org:8080/#/c/7274/2/src/kudu/integration-tests/master_migration-itest.cc File src/kudu/integration-tests/master_migration-itest.cc: Line 189: opts.bind_mode = MiniCluster::LOOPBACK; // Required since we use 127.0.0.1 in the config above. This means we should keep the master-rpc-ports RESOURCE for this test, no? -- To view, visit http://gerrit.cloudera.org:8080/7274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35eff9fbf5ccf8822cfe061673bc36598dff56f0 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
