Adar Dembo has posted comments on this change. Change subject: Use dynamic bind address for internal + external mini clusters ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7274/2/src/kudu/integration-tests/internal_mini_cluster.cc File src/kudu/integration-tests/internal_mini_cluster.cc: Line 124: mini_masters_.push_back(std::move(mini_master)); > I don't think so... emplace_back() is for calling the constructor. You can use them both, though you're right that the primary use case for emplace_back() is to forward arguments to the constructor. Anyway, it doesn't matter in this case. -- To view, visit http://gerrit.cloudera.org:8080/7274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35eff9fbf5ccf8822cfe061673bc36598dff56f0 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
