Todd Lipcon has posted comments on this change. Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS ......................................................................
Patch Set 5: Code-Review+1 (3 comments) just a few nits. Dan or Alexey should probably take a quick look as well. http://gerrit.cloudera.org:8080/#/c/6635/5/src/kudu/security/crypto.h File src/kudu/security/crypto.h: PS5, Line 78: cb nit: can we name this 'password_cb' or something? http://gerrit.cloudera.org:8080/#/c/6635/5/src/kudu/security/openssl_util.h File src/kudu/security/openssl_util.h: Line 101: Status GetPasswordFromShellCommand(const string& cmd, string* password); doc also use 'std::string' in headers http://gerrit.cloudera.org:8080/#/c/6635/5/src/kudu/security/tls_context.h File src/kudu/security/tls_context.h: Line 152: const PasswordCallback& cb) WARN_UNUSED_RESULT; nit: rename to password_cb -- To view, visit http://gerrit.cloudera.org:8080/6635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd6369581fa426ceab11e4a10441658c7da47e81 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
