Dan Burkert has posted comments on this change. Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6635/6/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: Line 162: CHECK_OK(security::CreateTestSSLCertWithEncryptedKey(GetTestDataDirectory(), > I wanted to add that but unfortunately StartTestServer() doesn't return a S So it fails an assert or a check? Perhaps a death test then, check out the gtest ASSERT_DEATH macro. Would probably require having it as a whole separate test case. -- To view, visit http://gerrit.cloudera.org:8080/6635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd6369581fa426ceab11e4a10441658c7da47e81 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
