Sailesh Mukil has posted comments on this change. Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS ......................................................................
Patch Set 9: Code-Review+2 > Build Successful > > http://jenkins.kudu.apache.org/job/kudu-gerrit/8758/ : SUCCESS The issue was that ASSERT_DEATH() emits a warning if the enclosed statement creates multiple threads as seen here in the docs: https://github.com/google/googletest/blob/master/googletest/docs/AdvancedGuide.md "A warning is emitted if multiple threads are running when a death test is encountered." This fails the ASSERT_DEATH() string comparison. To mitigate this, they suggest using a "threadsafe" option which somehow internally mitigates this (they didn't explain how): :testing::FLAGS_gtest_death_test_style = "threadsafe"; I've added that to the Bad password test. Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/6635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd6369581fa426ceab11e4a10441658c7da47e81 Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No
