Mike Percy has posted comments on this change. Change subject: Use dynamic bind address for internal + external mini clusters ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/7274/5/src/kudu/master/mini_master.h File src/kudu/master/mini_master.h: PS5, Line 48: loopback > is this correct? Done PS5, Line 77: StartOnPorts > rename this method (and the one below) Done http://gerrit.cloudera.org:8080/#/c/7274/5/src/kudu/tserver/mini_tablet_server.cc File src/kudu/tserver/mini_tablet_server.cc: PS5, Line 80: ports > addresses Done PS5, Line 84: Sockaddr bound_addr = bound_rpc_addr(); : opts_.rpc_opts.rpc_bind_addresses = bound_addr.ToString(); > can you combine these into one line? Done -- To view, visit http://gerrit.cloudera.org:8080/7274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35eff9fbf5ccf8822cfe061673bc36598dff56f0 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
