Dan Burkert has posted comments on this change. Change subject: MiniKdc: move common logic into test-utils ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7356/2/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: PS2, Line 368: vector<string> lines = strings::Split(lsof_out, "\n"); : int32_t p = -1; : if (lines.size() != 3 || : lines[2].substr(0, 3) != "n*:" || : !safe_strto32(lines[2].substr(3), &p) || : p <= 0) { : return Status::RuntimeError("unexpected lsof output", lsof_out) > For the TCP connections, it might happen the process not only started liste It's difficult to add the LISTEN flag, because it's not available for UDP sockets. I'm not too keen on adding a bunch of options to this method, because it seems to work pretty well right now, and if we need more from it we should probably rethink using lsof at all. -- To view, visit http://gerrit.cloudera.org:8080/7356 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f50e315f3e7ea16b3c73f058248c3dbd47d72e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
