Alexey Serbin has posted comments on this change. Change subject: MiniKdc: move common logic into test-utils ......................................................................
Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7356/2/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: PS2, Line 368: vector<string> lines = strings::Split(lsof_out, "\n"); : int32_t p = -1; : if (lines.size() != 3 || : lines[2].substr(0, 3) != "n*:" || : !safe_strto32(lines[2].substr(3), &p) || : p <= 0) { : return Status::RuntimeError("unexpected lsof output", lsof_out) > It's difficult to add the LISTEN flag, because it's not available for UDP s Well, it could be just an array (vector) of options to join using via '-a' flag, so for BindTcp it would be {"-i4TCP", "-sTCP:LISTEN"} and for BindUdp {"-i4UDP"}, while the WaitForBind() method could be refactored a bit to accept std::vector<string> as a parameter instead of the 'kind' string parameter. But if you feel it's not worth it, it's not a problem -- it can be added later. If needed, we can modify it while introducing support for multiple ports bound/listened. -- To view, visit http://gerrit.cloudera.org:8080/7356 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f50e315f3e7ea16b3c73f058248c3dbd47d72e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
