Todd Lipcon has posted comments on this change. Change subject: KUDU-1865: Avoid heap allocation for payload slices ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7471/1/src/kudu/rpc/inbound_call.h File src/kudu/rpc/inbound_call.h: PS1, Line 125: Slice slices[TransferLimits::kMaxPayloadSlices] I think using 'std::array<Slice, kMaxPayloadSlices>* slices' would be a bit more idiomatic here and elsewhere in the patch. The "fixed size array parameter" is pretty rarely used in C++ in my experience -- To view, visit http://gerrit.cloudera.org:8080/7471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4470d34ba48db5edaeb66d9e739e0c8942004d86 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
