Todd Lipcon has posted comments on this change. Change subject: KUDU-1865: Avoid heap allocation for payload slices ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/7471/3/src/kudu/rpc/inbound_call.cc File src/kudu/rpc/inbound_call.cc: Line 185: *(slice_iter++) = Slice(response_hdr_buf_); nit: the () here are not necessary, are they? Line 187: for (auto& sidecar : outbound_sidecars_) *(slice_iter++) = sidecar->AsSlice(); style: can you split this back onto multiple lines with braces? we rarely use single-line loops unless they are totally trivial like empty bodies http://gerrit.cloudera.org:8080/#/c/7471/3/src/kudu/rpc/outbound_call.cc File src/kudu/rpc/outbound_call.cc: Line 117: for (auto& sidecar : sidecars_) *(slice_iter++) = sidecar->AsSlice(); same -- To view, visit http://gerrit.cloudera.org:8080/7471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4470d34ba48db5edaeb66d9e739e0c8942004d86 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
