Adar Dembo has posted comments on this change. Change subject: raft_consensus-itest: another fix for asynchronous SIGSTOP ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7561/1/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: Line 2040: ASSERT_EVENTUALLY([&]{ On second thought, I'm not so sure about this. I spotted a similar looking failure with the fix. Perhaps if the first AddServer succeeds, subsequent AddServers will return InvalidArgument and not TimedOut, even if the majority of tservers are gone? /data/1/adar/kudu/src/kudu/integration-tests/raft_consensus-itest.cc:2044: Failure Value of: s.IsTimedOut() Actual: false Expected: true Expected AddServer() to time out. Result: Invalid argument: Server with UUID 3bfe5d6825be4d648e7d179427e7ce42 is already a member of the config. RaftConfig: opid _index: 3 OBSOLETE_local: false peers { permanent_uuid: "700da541e0524dff947f3321d0f62f45" member_type: VOTER last_known_addr { host: "127.56.176.4" port: 57412 } } peers { permanent_uuid: "89bc08641e5d4f32a466f276b1960697" member_type: VOTER last_known_addr { host: "127.56.176.1" port: 54832 } } peers { permanent_uuid: "bd8c3b95dd71464483296209a1571bca" member_type: VOTER last_known_addr { host: "127.56.176.3" port: 44271 } } peers { permanent_uuid: "15ba5d1429854802bccddd57f83 5dd0e" member_type: VOTER last_known_addr { host: "127.56.176.2" port: 45364 } } peers { permanent_uuid: "3bfe5d6825be4d648e7d179427e7ce42" member_type: VOTER la st_known_addr { host: "127.56.176.5" port: 35065 } } /data/1/adar/kudu/src/kudu/util/test_util.cc:273: Failure Failed Timed out waiting for assertion to pass. -- To view, visit http://gerrit.cloudera.org:8080/7561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99d400e971d6f9b22cc7b4483db94a98ec306e10 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
