Adar Dembo has posted comments on this change. Change subject: subprocess: even more robust fix for asynchronous signals ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7561/6/src/kudu/util/subprocess-test.cc File src/kudu/util/subprocess-test.cc: Line 302: ASSERT_EVENTUALLY([&]{ > why do these need EVENTUALLY? isn't the point of the changes you made to Ki Oops. An earlier iteration of the patch used kill(2) directly, and so ASSERT_EVENTUALLY was relevant. I'll remove it. -- To view, visit http://gerrit.cloudera.org:8080/7561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99d400e971d6f9b22cc7b4483db94a98ec306e10 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
