Todd Lipcon has posted comments on this change. Change subject: Give more context on errors reading cfiles ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7620/1/src/kudu/cfile/cfile_reader.cc File src/kudu/cfile/cfile_reader.cc: Line 196: return Status::Corruption("invalid CFile header size", std::to_string(header_size)); > would it be possible to display the data directory? this might hint at a fa The block id doesn't need to be here in the ReadAndParseHeader code because this is only called by Init() which includes the block id. Including the data dir is a nice idea. Mind if I postpone that to a separate patch since I think it's a bit more complicated? (have to add a new method to ReadableBlock and perhaps do a bit of plumbing) -- To view, visit http://gerrit.cloudera.org:8080/7620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bda5688a020032c512235ee574cb3e53c7872af Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
