Todd Lipcon has submitted this change and it was merged. Change subject: Give more context on errors reading cfiles ......................................................................
Give more context on errors reading cfiles Recently, a user reported an error loading a tablet in which the only reported message was "bad magic". This wasn't useful for pinpointing the id of the bad block or what might have happened to cause the problem. This patch adds more context info in such circumstances: we now include DebugString output for "bad magic" errors as well as the block ID in all cases. The unit test is updated to check that block IDs show up in all Corruption status messages. Change-Id: I0bda5688a020032c512235ee574cb3e53c7872af Reviewed-on: http://gerrit.cloudera.org:8080/7620 Reviewed-by: Adar Dembo <a...@cloudera.com> Tested-by: Kudu Jenkins --- M src/kudu/cfile/cfile-test.cc M src/kudu/cfile/cfile_reader.cc M src/kudu/cfile/index_btree.cc M src/kudu/tablet/deltafile.cc 4 files changed, 52 insertions(+), 19 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bda5688a020032c512235ee574cb3e53c7872af Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
