Hao Hao has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager ......................................................................
Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/7207/14/src/kudu/fs/block_manager-stress-test.cc File src/kudu/fs/block_manager-stress-test.cc: Line 282: dirty_blocks.emplace_back(std::move(block)); > use emplace_back with r-value references. Done http://gerrit.cloudera.org:8080/#/c/7207/13/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 278: Status FinishBlock(const Status& s, WritableBlock* block, > Yah I didn't realize it was being called in a closure. Still, you could re Thanks for pointing out! I personally prefer to keep it as the way it is, because inside FinishBlock(), if the input status is not ok, we need to mark the container as read-only. Or maybe you have other thought? http://gerrit.cloudera.org:8080/#/c/7207/14/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 1524: RETURN_NOT_OK_PREPEND(s, "unable to append block metadata"); > here and abve, start the message with a lowercase ('unable', 'container'). Done -- To view, visit http://gerrit.cloudera.org:8080/7207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01f3ed830cc1f86d7bb8a66b2f780914a88884bd Gerrit-PatchSet: 15 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
