Hao Hao has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager ......................................................................
Patch Set 16: (4 comments) http://gerrit.cloudera.org:8080/#/c/7207/16/src/kudu/cfile/cfile-test.cc File src/kudu/cfile/cfile-test.cc: Line 423: class TestCFileBothCacheTypesCloseTypes : public TestCFile, > You should be able to use this to replace TestCFileBothCacheTypes. Here's w Done Line 449: if (desc.close_type == CLOSE) FLAGS_cfile_close_blocks_on_finish = true; > If the default value of this gflag changes to true, we'll never test the fa Done http://gerrit.cloudera.org:8080/#/c/7207/16/src/kudu/cfile/cfile_writer.cc File src/kudu/cfile/cfile_writer.cc: PS16, Line 59: // - users could always change this to "close", which slows down throughput : // but may improve write latency. > This part isn't quite right anymore. Should the entire comment be rewritten Done PS16, Line 63: > Nit: got an extra space here. Done -- To view, visit http://gerrit.cloudera.org:8080/7207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01f3ed830cc1f86d7bb8a66b2f780914a88884bd Gerrit-PatchSet: 16 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
