Todd Lipcon has posted comments on this change. Change subject: KUDU-2101 Include a table summary at the bottom ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7707/1/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: PS1, Line 222: push_back emplace_back(std::move(ts)) Line 231: // The table summary is in alphabetical order by name. is this best or should we put the unhealthy tables at the bottom, so that when you have more than a page full of tables the bad ones stick out? PS1, Line 239: vector<string> names; : vector<string> statuses; : vector<string> total_tablets; : vector<string> num_healthy; : vector<string> num_underreplicated; : vector<string> num_unhealthy; is using the 'AddRow' interface not fewer lines of code / easier to follow here? PS1, Line 255: UNHEALTHY I find "UNHEALTHY" to be a little confusing. Should we say "unavailable" or something to be more precise? I was a little confused when I saw output that said "0 under-replicated but 1 unhealthy". Is under-replicated not unhealthy in some sense? -- To view, visit http://gerrit.cloudera.org:8080/7707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1913352e3a1f91b4bb07e2f5001c8cc94d5155d4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
