Todd Lipcon has posted comments on this change. Change subject: KUDU-2032 (part 2): propagate master hostnames into client ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7692/2/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: Line 708: // TODO: Do address resolution asynchronously as well. > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/7692/2/src/kudu/client/master_rpc.cc File src/kudu/client/master_rpc.cc: PS2, Line 92: / > nit: remove Done http://gerrit.cloudera.org:8080/#/c/7692/2/src/kudu/client/master_rpc.h File src/kudu/client/master_rpc.h: Line 22: #include <vector> > warning: #includes are not sorted properly [llvm-include-order] Done -- To view, visit http://gerrit.cloudera.org:8080/7692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5838f22c96f757124112b505825a53740468ce1 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
