Todd Lipcon has posted comments on this change. Change subject: KUDU-2032 (part 2): propagate master hostnames into client ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7692/5/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: Line 631: const pair<Sockaddr, string>& leader_addr_and_name, > Why not two separate params? Then you could even move the leader_hostname I actually started with that, but because the addr_and_name pairs are fed into the ConnectToCluster stuff in a vector<pair<>> it seemed cleaner to keep the same pair type on its callback. -- To view, visit http://gerrit.cloudera.org:8080/7692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5838f22c96f757124112b505825a53740468ce1 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
