Alexey Serbin has posted comments on this change. Change subject: [iwyu] first pass ......................................................................
Patch Set 18: (3 comments) > Other than the 1 nit in sp::shared_ptr, this looks good to me Great -- thank you for reviewing this jumbo-patch. I'll update the patch to include <tr1/memory> instead of <kudu/client/shared_ptr.h> http://gerrit.cloudera.org:8080/#/c/4738/19/src/kudu/client/shared_ptr.h File src/kudu/client/shared_ptr.h: Line 55: #include <tr1/memory> // IWYU pragma: export > remove this one as well OK, will do, but then it will be necessary to include <tr1/memory> in many places instead of "kudu/client/shared_ptr.h". Sometimes, it will be the case when both <memory> and <tr1/memory> are required. But after looking at it once more, I think that would be a better option to have from the beginning. http://gerrit.cloudera.org:8080/#/c/4738/18/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: Line 387: std::ostream* out = nullptr); > I'm ok with moving the impl, but I was just curious about why you changed t Because the default value required to include <iostream>, which is very heavy header. http://gerrit.cloudera.org:8080/#/c/4738/18/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: Line 33: #include <boost/smart_ptr/shared_ptr.hpp> > ahh, I do remember dealing with this some time in the way past around the t yep, that's for yield. -- To view, visit http://gerrit.cloudera.org:8080/4738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6923091be36a1c03fac34dd73e6b17e17ac9ceaa Gerrit-PatchSet: 18 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
