Dan Burkert has posted comments on this change. Change subject: [iwyu] first pass ......................................................................
Patch Set 21: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4738/19/src/kudu/client/shared_ptr.h File src/kudu/client/shared_ptr.h: Line 55: #include <tr1/memory> // IWYU pragma: export > After looking at this once more, I think having these 'IWYU pragma: export' OK I think I misunderstood how IWYU works initially, then. I didn't think IWYU would also force you to include <memory> or <tr1/memory> when working with sp::shared_ptr. Since the whole point of this header is to _avoid_ doing that when working with sp::shared_ptr, I agree we should leave the annotation on. -- To view, visit http://gerrit.cloudera.org:8080/4738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6923091be36a1c03fac34dd73e6b17e17ac9ceaa Gerrit-PatchSet: 21 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
