Adar Dembo has posted comments on this change. Change subject: rpc: periodic timers ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/7733/1/src/kudu/rpc/periodic-test.cc File src/kudu/rpc/periodic-test.cc: Line 70: SleepFor(MonoDelta::FromMilliseconds(period_ms_ * 2)); > warning: either cast from 'int' to 'int64_t' (aka 'long') is ineffective, o Done Line 76: SleepFor(MonoDelta::FromMilliseconds(period_ms_ * 2)); > warning: either cast from 'int' to 'int64_t' (aka 'long') is ineffective, o Done Line 96: if (now - start_time > MonoDelta::FromMilliseconds(period_ms_ * 5)) { > warning: either cast from 'int' to 'int64_t' (aka 'long') is ineffective, o Done Line 107: timer_->Reset(MonoDelta::FromMilliseconds(period_ms_ * 5)); > warning: either cast from 'int' to 'int64_t' (aka 'long') is ineffective, o Done Line 120: timer_->Start(MonoDelta::FromMilliseconds(period_ms_ * 5)); > warning: either cast from 'int' to 'int64_t' (aka 'long') is ineffective, o Done http://gerrit.cloudera.org:8080/#/c/7733/1/src/kudu/rpc/periodic.cc File src/kudu/rpc/periodic.cc: Line 76: Reset(next_task_delta); > warning: parameter 'next_task_delta' is passed by value and only copied onc Done -- To view, visit http://gerrit.cloudera.org:8080/7733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23f80631a5591b1ac023974f3d7d9eb1576cdb86 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
