Dan Burkert has posted comments on this change. Change subject: rpc: periodic timers ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7733/2/src/kudu/rpc/periodic-test.cc File src/kudu/rpc/periodic-test.cc: PS2, Line 51: () The parens are optional when empty (just like the return value). Don't feel the need to change it, but I found that out recently and I think it tends to look a bit cleaner. http://gerrit.cloudera.org:8080/#/c/7733/2/src/kudu/rpc/periodic.h File src/kudu/rpc/periodic.h: Line 97: void Reset(boost::optional<MonoDelta> next_task_delta = boost::none); May want to add a note that next_task_delta must be > GetMinimumPeriod(), otherwise it's not guaranteed to fire in a timely manner. -- To view, visit http://gerrit.cloudera.org:8080/7733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23f80631a5591b1ac023974f3d7d9eb1576cdb86 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
