Adar Dembo has posted comments on this change. Change subject: [build-support] IWYU build configuration for Jenkins ......................................................................
Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/7750/8/CMakeLists.txt File CMakeLists.txt: PS8, Line 119: # Generate a Clang compile_commands.json "compilation database" file for use : # with various development tools, such as Vim's YouCompleteMe plugin. : # See http://clang.llvm.org/docs/JSONCompilationDatabase.html : if ("$ENV{CMAKE_EXPORT_COMPILE_COMMANDS}" STREQUAL "1") : set(CMAKE_EXPORT_COMPILE_COMMANDS 1) : endif() Don't need this anymore? Also update .ycm_extra_conf.py. Line 1058: # "make iwyu" target Should we provide two targets like with lint, where one is 'incremental' and one is 'full'? http://gerrit.cloudera.org:8080/#/c/7750/8/build-support/iwyu/iwyu.sh File build-support/iwyu/iwyu.sh: Line 23: trap "rm -f $IWYU_LOG" EXIT Does this remove IWYU_LOG on the various "exit 0" and "exit 1" paths out of the script? Line 52: tee $IWYU_LOG If we're removing IWYU_LOG on exit, what's the point of redirecting to it at all? Why not just pipe the filtered output to the console and be done with it? Line 60: exit 0 When this path is taken, is there enough console output to make it clear what there are no recommendations and everything is good? -- To view, visit http://gerrit.cloudera.org:8080/7750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45f2e8529891dd7da18c9fa6383e0c41e6b4182e Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
