Alexey Serbin has posted comments on this change. Change subject: [build-support] IWYU build configuration for Jenkins ......................................................................
Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7750/8/CMakeLists.txt File CMakeLists.txt: PS8, Line 119: # Generate a Clang compile_commands.json "compilation database" file for use : # with various development tools, such as Vim's YouCompleteMe plugin. : # See http://clang.llvm.org/docs/JSONCompilationDatabase.html : if ("$ENV{CMAKE_EXPORT_COMPILE_COMMANDS}" STREQUAL "1") : set(CMAKE_EXPORT_COMPILE_COMMANDS 1) : endif() > But this part of .ycm_extra_conf.py is no longer needed, since it'll now al Ah, sure -- good catch! -- To view, visit http://gerrit.cloudera.org:8080/7750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45f2e8529891dd7da18c9fa6383e0c41e6b4182e Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
