Adar Dembo has posted comments on this change. Change subject: [java] Gradle test task improvements ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7782/1//COMMIT_MSG Commit Message: Trailing whitespace. PS1, Line 11: d: Ifb660b15423b68c299518b7ba54a15135972a007 : Surefire doesn't do this in Maven (at least not within a module; there's a separate JVM per module though), so why should the Gradle-based tests be any more or less flaky by reusing a JVM? IIRC reusing a JVM means the tests run faster. http://gerrit.cloudera.org:8080/#/c/7782/1/java/gradle/tests.gradle File java/gradle/tests.gradle: Line 39: // Set a few system properties. Should we also set -Xmx1900m? I see that in Maven's testArgLine property. -- To view, visit http://gerrit.cloudera.org:8080/7782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
